Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue hmr #1094

Merged
merged 3 commits into from
Aug 26, 2023
Merged

fix: vue hmr #1094

merged 3 commits into from
Aug 26, 2023

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Aug 26, 2023

closes #1092

Initially support Vue HMR of the latest @vitejs/plugin-vue. Removed hacked internal handleHotUpdate that from @vitejs/plugin-vue for avoiding breaking changes in the future.

For support finer-grained update, now needs to be handled HMR logic, comparing which part script or template is changed, by slidev itself. (didn't do in this PR)

@antfu antfu merged commit 5ce92a0 into slidevjs:main Aug 26, 2023
8 checks passed
@sxzz sxzz deleted the fix/vue-hmr branch August 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hot reloading not working
2 participants