Remove rustc compiler features to unbreak rustc nightly build #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems a pinned version of rustc nightly is pinned in CI, should i bump this too? |
|
after looking into it a bit, it seems the latest version of rustc nightly compatible with miri determines which nightly is going to be used, so it's depending on external things that might be hard to fix here? Not sure what to do at this point. |
- following landing of rust-lang/rust#73858, the `const_saturing_int_methods` feature is in a weird nonexisting state (stabilized in a future Rust version), so remove it from the list to unblock compilation. - also remove other const features that have stabilized in the meanwhile to avoid compiler warnings.
bnjbvr
force-pushed
the
unbreak-nightly-build
branch
from
9121a3d
to
95c9f5a
Compare
|
Now that miri is available in a more recent nightly, the test passes again, yay. @slightlyoutofphase Can you take a look, please? Thanks! |
|
I noticed this PR right after I noticed the automated tests were failing and had already fixed the issues myself. Thanks for being on the ball though, and sorry it took me a little bit to get this all taken care of! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
const_saturing_int_methodsfeature is in a weird nonexistingstate (stabilized in a future Rust version), so remove it from the list
to unblock compilation.
meanwhile to avoid compiler warnings.