Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setMethods with addMethods #252

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Replace setMethods with addMethods #252

merged 4 commits into from
Feb 18, 2022

Conversation

nbayramberdiyev
Copy link
Contributor

@nbayramberdiyev nbayramberdiyev commented Feb 18, 2022 •
edited
Loading

Closes #207

@coveralls
Copy link

coveralls commented Feb 18, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 100.0% when pulling 07e48ea on nbayramberdiyev:replace-setMethods into ec3d622 on slimphp:master.

l0gicgate
l0gicgate requested changes Feb 18, 2022
View reviewed changes
tests/ResponseTest.php Outdated Show resolved Hide resolved
@l0gicgate l0gicgate added this to the 1.6 milestone Feb 18, 2022
l0gicgate
l0gicgate approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution 👍🏼

@l0gicgate l0gicgate merged commit 1a5a6cd into slimphp:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Replace deprecated setMethods()
3 participants
@nbayramberdiyev @coveralls @l0gicgate