Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for protected \Slim\Psr7\Stream::attach method #80

Merged
merged 1 commit into from
May 3, 2019
Merged

Add test case for protected \Slim\Psr7\Stream::attach method #80

merged 1 commit into from
May 3, 2019

Conversation

adriansuter
Copy link
Contributor

This test case would test, if the detach method gets called in case the attach method is called but there was already a stream attached.

This is maybe an overkill as this method would actually only be called on construction of a new \Slim\Psr7\Stream. Of course, in this case, there is no stream attached.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.752% when pulling a39217d on adriansuter:patch-streamTest into 84c7a0a on slimphp:master.

@l0gicgate l0gicgate added this to the 0.1 milestone May 3, 2019
@l0gicgate l0gicgate merged commit 7ff219c into slimphp:master May 3, 2019
@adriansuter adriansuter deleted the patch-streamTest branch May 3, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansuter @coveralls @l0gicgate