-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optional type $description in ActionError can not be set to null
#290
Fix optional type $description in ActionError can not be set to null
#290
Conversation
This would be a breaking change. Instead, we should correct the type to be properly nullable. |
@l0gicgate sorry for the late response, how would it be a breaking change? Setting the value to |
@Dmitrev you just answered your own question. Changing a nullable constructor parameter to non nullable is a breaking change. That means it’s not backward compatible. I know that this is a skeleton repo and it wouldn’t break things downstream but that’s not the point. Also, this parameter should be nullable as you may not always pass an error message. |
@l0gicgate Sorry I have to disagree with you here. It is already broken as is. Passing See example:
Same with the setter
It cannot be a breaking change, if it never worked to begin with... I am happy for it to be nullable, can change that |
@Dmitrev you’re right it’s already broken. The constructor is fine, the property itself should be nullable though as I mentioned. |
@l0gicgate updated it with your suggestion |
null
Thank you for your contribution @Dmitrev |
Please see this issue for context:
#289