#1836 count amount of bytes read instead of chunks

[llvdl]

No description provided.

[llvdl]

This is a fix for #1836 where not all data is read if StreamInterface::read returns less than the request amount of bytes.

[akrabat]

Unit tests fail in testRespondWithPaddedStreamFilterOutput.

[akrabat]

Suggested fix:

diff --git a/Slim/App.php b/Slim/App.php
index cd478f1..e65c6e4 100644
--- a/Slim/App.php
+++ b/Slim/App.php
@@ -386,6 +386,9 @@ class App
             if (isset($contentLength)) {
                 $amountToRead = $contentLength;
                 while ($amountToRead > 0 && !$body->eof()) {
+                    if ($amountToRead < $chunkSize) {
+                        $chunkSize = $amountToRead;
+                    }
                     $data = $body->read($chunkSize);
                     echo $data;

[llvdl]

The unit tests run without problems on my local environment (Xubuntu 15.10, PHP 5.6.11), but fail on Travis.

If you could help me reproduce the failing test locally, then I would appreciat it. I can probably get on IRC tonigh (CET).

[akrabat]

You need to install the mcrypt PHP extension locally as the test that's failing only runs if that's installed.

[llvdl]

Thanks!

[llvdl]

Hmm.. installed php5-mcrypt, but the test still succeeds.

[akrabat]

Can you see mcrypt in the list when you run php -m ?

[llvdl]

mcrypt does not show up, I will investigate why.

The fix you suggested seems to do the trick! Thanks for looking into this.

[akrabat]

Thanks!