Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handlers throws exception if content-type not supported #1866

Merged
merged 2 commits into from
May 16, 2016
Merged

Error handlers throws exception if content-type not supported #1866

merged 2 commits into from
May 16, 2016

Conversation

dopesong
Copy link
Contributor

@dopesong dopesong commented May 9, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.975% when pulling 9d7ea1a on dopesong:default-error-output into 954472c on slimphp:3.x.

@akrabat
Copy link
Member

akrabat commented May 9, 2016

Please make it throw an exception as determineContentType should mean that the default never happens.

@dopesong dopesong force-pushed the default-error-output branch from 9d7ea1a to 2068b27 Compare May 9, 2016 07:33
@dopesong dopesong changed the title text/html output now default for error handlers switches Error handlers throws exception if content-type not supported May 9, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.374% when pulling 2068b27 on dopesong:default-error-output into 954472c on slimphp:3.x.

@akrabat
Copy link
Member

akrabat commented May 9, 2016

Needs tests.

@dopesong
Copy link
Contributor Author

dopesong commented May 9, 2016

Will be added + additional to increase coverage 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 88.442% when pulling f100ab9 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from fa744ce to 042cd12 Compare May 12, 2016 09:48
@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 90.578% when pulling 042cd12 on dopesong:default-error-output into 954472c on slimphp:3.x.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 90.578% when pulling 042cd12 on dopesong:default-error-output into 954472c on slimphp:3.x.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 87.94% when pulling ff147b9 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from ff147b9 to edef90a Compare May 12, 2016 10:36
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 87.94% when pulling edef90a on dopesong:default-error-output into 954472c on slimphp:3.x.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 90.452% when pulling 28b9734 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from 28b9734 to 79a4944 Compare May 12, 2016 10:59
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 90.452% when pulling 79a4944 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from 79a4944 to b795e5a Compare May 12, 2016 11:06
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 90.452% when pulling b795e5a on dopesong:default-error-output into 954472c on slimphp:3.x.

@geggleto
Copy link
Member

@dopesong Don't forget to squash the commit :D

@dopesong dopesong force-pushed the default-error-output branch from b795e5a to b790544 Compare May 12, 2016 13:44
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 90.452% when pulling b790544 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from b790544 to dfe1b06 Compare May 12, 2016 18:17
@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 92.462% when pulling dfe1b06 on dopesong:default-error-output into 954472c on slimphp:3.x.

@dopesong dopesong force-pushed the default-error-output branch from dfe1b06 to c579f19 Compare May 12, 2016 18:42
@coveralls
Copy link

Coverage Status

Coverage increased (+5.4%) to 93.342% when pulling c579f19 on dopesong:default-error-output into 954472c on slimphp:3.x.

@akrabat akrabat added this to the 3.4.1 milestone May 16, 2016
@akrabat akrabat merged commit c579f19 into slimphp:3.x May 16, 2016
akrabat added a commit that referenced this pull request May 16, 2016
@akrabat
Merge branch 'dopesong-default-error-output' into 3.x
448d9a6 
Closes #1866
@mathmarques mathmarques mentioned this pull request May 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dopesong @coveralls @akrabat @geggleto