Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows tests #2068

Merged
merged 2 commits into from
Nov 26, 2016
Merged

Fix Windows tests #2068

merged 2 commits into from
Nov 26, 2016

Conversation

DavidePastore
Copy link
Contributor

Closes #1944.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.258% when pulling e43ccae on DavidePastore:fix-phpunit-windows into 686bfc2 on slimphp:3.x.

akrabat
akrabat reviewed Nov 22, 2016
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a space around the '.' please?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.258% when pulling 4607a7c on DavidePastore:fix-phpunit-windows into 686bfc2 on slimphp:3.x.

@codeguy
Copy link
Member

codeguy commented Nov 22, 2016

I included the same fix in my PR against 4.x. Not enough Windows users on the project ;)

@DavidePastore
Copy link
Contributor Author

Yes @codeguy , "don't reinvent the wheel" 😸

@akrabat akrabat merged commit 4607a7c into slimphp:3.x Nov 26, 2016
@akrabat akrabat added this to the 3.7.0 milestone Nov 26, 2016
@DavidePastore DavidePastore deleted the fix-phpunit-windows branch November 28, 2016 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidePastore @coveralls @codeguy @akrabat