Support rendering Exceptions with previous Errors #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an Exception is thrown with an Error set as it's previous then we need to render this correctly in the error handler. This simply requires removing the type hint, however we can't do that for BC, so I've created the method `renderHtmlExceptionOrError` which is now used. Fixes #1943
chrisemerson
reviewed
Jan 9, 2017
| * | ||
| * @return string | ||
| */ | ||
| protected function renderHtmlExceptionOrError($exception) |
There was a problem hiding this comment.
You could simplify this by hinting for Throwable instead - both Error and Exception implement this interface
There was a problem hiding this comment.
Throwable doesn't exist in PHP5, so it's better to be specific.
There was a problem hiding this comment.
Ah of course, I had forgotten about the support requirements!
codeguy
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Exception is thrown with an Error set as it's previous then we
need to render this correctly in the error handler. This simply requires
removing the type hint, however we can't do that for BC, so I've created
the method
renderHtmlExceptionOrErrorwhich is now used.Fixes #1943