-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invalid XML better #2122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this not a BC break, since we are now suppressing a PHP error? |
I think it's a bug fix. Will go with majority opinion though. |
silentworks
approved these changes
Jan 13, 2017
@akrabat Forward port to 4.x too? |
Yes. |
Do we want a test for this? |
Almost certainly :) |
Will merge once you get a test added. |
If the request's body contains invalid XML, don't throw an exception or PHP warning. Instead, just return NULL from the medica parser. This matches the way we handle JSON. Fixes #2106
Rebased and added unit tests. |
Success, @codeguy :) |
codeguy
added a commit
that referenced
this pull request
Mar 7, 2017
Can this go into 4.x too, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request's body contains invalid XML, don't throw an exception or
PHP warning. Instead, just return NULL from the medica parser.
This matches the way we handle JSON.
Fixes #2106