Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated consistent name request and response in MiddlewareAwareTrait #2136

Merged
merged 3 commits into from Jan 30, 2017
Merged

updated consistent name request and response in MiddlewareAwareTrait #2136

merged 3 commits into from Jan 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2017

Hi all,
as discussed briefly here #2133. I'd like to make more consistent use of the variables names, also and specifically $request and $response, instead of using sometimes those and sometimes $req and $res.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.928% when pulling eafabd4 on 0x13a:consistent-name-request-response into fb5356a on slimphp:3.x.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.928% when pulling 0e4f580 on 0x13a:consistent-name-request-response into fb5356a on slimphp:3.x.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 97.931% when pulling 7869ac1 on 0x13a:consistent-name-request-response into fb5356a on slimphp:3.x.

@ghost
Copy link
Author

ghost commented Jan 26, 2017

yes, i need to setup the psr2 sniffer.. Anyway ready to merge @akrabat

@tuupola
Copy link
Contributor

tuupola commented Jan 26, 2017

To check for PSR-2 run either $ composer phpcs or $ vendor/bin/phpcs in Slim folder.

https://github.com/slimphp/Slim/blob/3.x/composer.json#L55

@ghost
Copy link
Author

ghost commented Jan 26, 2017

thanks @tuupola

akrabat added a commit that referenced this pull request Jan 30, 2017
updated consistent name request and response in MiddlewareAwareTrait
akrabat added a commit that referenced this pull request Jan 30, 2017
@akrabat akrabat merged commit 7869ac1 into slimphp:3.x Jan 30, 2017
akrabat added a commit that referenced this pull request Jan 30, 2017
@akrabat akrabat added this to the 3.8.0 milestone Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants