Output buffer middleware #2166
Merged
Output buffer middleware #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes so far include:
|
codeguy
changed the title
akrabat
requested changes
Mar 8, 2017
akrabat
requested changes
Mar 8, 2017
| @@ -296,36 +276,11 @@ public function testInvokeWhenEchoingOutput() | |||
| public function testInvokeWhenReturningAString() | |||
There was a problem hiding this comment.
I think this test should return a string and expect an Exception to happen?
There was a problem hiding this comment.
@akrabat I think the name of the test should change. This test should be renamed.
testEchoingOutputIsEmpty
testReturningStringThrowsException ?
geggleto
requested changes
Mar 9, 2017
| // TODO: Do we keep output buffering? | ||
| if (is_callable([$route, 'setOutputBuffering'])) { | ||
| $route->setOutputBuffering($this->getSetting('outputBuffering', 'append')); | ||
| } |
There was a problem hiding this comment.
I honestly think that we can remove it.
Dump and Die will still work, which is I feel what a majority of people do anyway.
| @@ -296,36 +276,11 @@ public function testInvokeWhenEchoingOutput() | |||
| public function testInvokeWhenReturningAString() | |||
There was a problem hiding this comment.
@akrabat I think the name of the test should change. This test should be renamed.
testEchoingOutputIsEmpty
testReturningStringThrowsException ?
danopz
reviewed
Jun 9, 2017
| ob_start(); | ||
| $newResponse = $next($req, $res); | ||
| $output = ob_get_clean(); | ||
| } catch (\Throwable $e) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Opening PR for feedback.