Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container #2290

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Remove container #2290

merged 4 commits into from
Nov 3, 2017

Commits on Nov 3, 2017

  1. Remove InvalidMethodException 

    It's not used as process() catches everything.
    @akrabat
    akrabat committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    1377150 View commit details
    Browse the repository at this point in the history

  2. Remove Container 

    Container is now completely optional. App now creates its own request
and response in `run()` and the rest of the objects in
`DefaultServicesProvider` were already defined within `App`.

Also removed the magic `__call` method on `App` that allows access to
the container as there's no need for it.

Note that Pimple is a dev dependency for testing routing,
`CallableResolver` and `DeferredCallable`.

AppTest has also been tidied a little.

Closes #2288
    @akrabat
    akrabat committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    707ea97 View commit details
    Browse the repository at this point in the history

  3. Require Pimple 3.2+ in dev for PSR11 wrappers

    @akrabat
    akrabat committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    4d3f342 View commit details
    Browse the repository at this point in the history

  4. Removed Collection and CollectionInterface 

    These were only being used by Container which is now gone.
    @akrabat
    akrabat committed Nov 3, 2017
    2 Configuration menu
    Copy the full SHA
    8385ca7 View commit details
    Browse the repository at this point in the history