Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-15 Middleware Support #2555

Merged
merged 75 commits into from
Feb 22, 2019
Merged

PSR-15 Middleware Support #2555

merged 75 commits into from
Feb 22, 2019

Commits on Feb 14, 2019

  1. add http-server-middleware dependency in composer.json

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    da13a4e View commit details
    Browse the repository at this point in the history

  2. add MiddlewareRunner, LegacyMiddlewareWrapper and supporting logic in… 

    … core components
    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5f49eb5 View commit details
    Browse the repository at this point in the history

  3. convert existing middleware to PSR-15 synthax

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    d5ee2f2 View commit details
    Browse the repository at this point in the history

  4. add supporting test suite for all changes

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    8eeb1c6 View commit details
    Browse the repository at this point in the history

  5. fix typo in README

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6e14297 View commit details
    Browse the repository at this point in the history

  6. fix exceeded line lengths in multiple files

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    b778f57 View commit details
    Browse the repository at this point in the history

  7. fix coding standard error in Route

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    4948c6f View commit details
    Browse the repository at this point in the history

  8. add test coverage for App::setContainer() to ensure CallableResolver … 

    …has appropriate container
    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9d831b4 View commit details
    Browse the repository at this point in the history

  9. add test coverage for Route::add()

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5164b7a View commit details
    Browse the repository at this point in the history

  10. fix typo in README

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    8b7b00b View commit details
    Browse the repository at this point in the history

  11. add ability to defer instantiation for PSR-15 middleware

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    310f448 View commit details
    Browse the repository at this point in the history

  12. add supporting tests for deferred PSR-15 instantiation

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    53d081e View commit details
    Browse the repository at this point in the history

  13. fix RouteGroupInterface error

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    f750764 View commit details
    Browse the repository at this point in the history

  14. refactor middleware adding logic to detect type of middleware

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    e7187a2 View commit details
    Browse the repository at this point in the history

  15. add supporting tests

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    b284fc4 View commit details
    Browse the repository at this point in the history

  16. fix doc block in DeferredResolutionMiddlewareWrapper

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    712e326 View commit details
    Browse the repository at this point in the history

  17. add setContainer method on CallableResolver interface and supporting … 

    …tests
    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    95070ad View commit details
    Browse the repository at this point in the history

  18. refactor logic for App::setContainer() to update CallableResolver con… 

    …tainer
    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a7881c0 View commit details
    Browse the repository at this point in the history

  19. rename DeferredResolutionMiddlewareWrapper and Psr7MiddlewareWrapper

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    0fb790f View commit details
    Browse the repository at this point in the history

  20. add doc blocs to middleware classes

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    8c38706 View commit details
    Browse the repository at this point in the history

  21. Separate routing detection from App into its own middleware

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9a95ba2 View commit details
    Browse the repository at this point in the history

  22. add supporting test for RoutingDetectionMiddleware

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    94949a1 View commit details
    Browse the repository at this point in the history

  23. replace string class names with string constants in AppTest

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    dcdb6b8 View commit details
    Browse the repository at this point in the history

  24. fix rebase errors

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a2cf3fe View commit details
    Browse the repository at this point in the history

  25. fix line length in AppTest

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    ca7497b View commit details
    Browse the repository at this point in the history

  26. fix phpcs error

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    4fe2e5a View commit details
    Browse the repository at this point in the history

  27. add deferred Router resolving for RoutingDetectionMiddleware

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    738388f View commit details
    Browse the repository at this point in the history

  28. make RouteGroup reference CallableResolver from Router instead of App

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    cac5e5c View commit details
    Browse the repository at this point in the history

  29. rename instances of LegacyMiddlewareWrapper to Psr7MiddlewareAdapter

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    2460d1e View commit details
    Browse the repository at this point in the history

  30. fix synthax in README

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5ef7c2c View commit details
    Browse the repository at this point in the history

  31. add ClosureMiddleware and retrofit unit tests to use it

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a68ed58 View commit details
    Browse the repository at this point in the history

  32. refactor MiddlewareRunner to spawn independant runner for sub-request… 

    … support
    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5bb76d6 View commit details
    Browse the repository at this point in the history

  33. remove callable support in add method to force MiddlewareInterface usage

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    3e6c67a View commit details
    Browse the repository at this point in the history

  34. add deferred resolvers Container, CallableResolver and Router

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    bdcaad7 View commit details
    Browse the repository at this point in the history

  35. refactor tests to reflect deferred resolvers changes

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    98df6db View commit details
    Browse the repository at this point in the history

  36. remove files from slimphp#2380 patch skipped during rebase

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    1bf492e View commit details
    Browse the repository at this point in the history

  37. reorganize getters and setters in App

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    0f692c9 View commit details
    Browse the repository at this point in the history

  38. fix PHPCS errors

    @l0gicgate
    l0gicgate committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    3122b90 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. add test coverage for Router getDefaultInvocationStrategy and getCall… 

    …ableResolver
    @l0gicgate
    l0gicgate committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    97af983 View commit details
    Browse the repository at this point in the history

  2. add test for Routable DeferredMiddleware string resolution in add() m… 

    …ethod
    @l0gicgate
    l0gicgate committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    d18bdac View commit details
    Browse the repository at this point in the history

  3. add extra test coverage for OutputBufferingMiddleware

    @l0gicgate
    l0gicgate committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    2f27250 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. fix errors in README

    @l0gicgate
    l0gicgate committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    3922fe2 View commit details
    Browse the repository at this point in the history

  2. rename RoutingDetectionMiddleware to DispatchMiddleware

    @l0gicgate
    l0gicgate committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    47708f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. remove App setters and modify constructor, add Closure middleware sup… 

    …port in add() method
    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    afaddbe View commit details
    Browse the repository at this point in the history

  2. make changes to CallableResolver interface

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    7c6581c View commit details
    Browse the repository at this point in the history

  3. make changes to RouteGroupInterface, RouteInterface and RouterInterface

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    ba7b324 View commit details
    Browse the repository at this point in the history

  4. make changes to Routable, Route, RouteGroup and Router to support int… 

    …erface changes
    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    81c65a9 View commit details
    Browse the repository at this point in the history

  5. change middleware ContainerInterface referencing

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    a3ef232 View commit details
    Browse the repository at this point in the history

  6. fix all supporting tests

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    b9eae84 View commit details
    Browse the repository at this point in the history

  7. fix README docblocks

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    819bb64 View commit details
    Browse the repository at this point in the history

  8. add missing App tests

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    a18fb6d View commit details
    Browse the repository at this point in the history

  9. add missing Route tests

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    24bcd44 View commit details
    Browse the repository at this point in the history

  10. removing unused constants from RouterInterface

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    cd238dd View commit details
    Browse the repository at this point in the history

  11. add type hinting to App::getContainer()

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    148f85d View commit details
    Browse the repository at this point in the history

  12. reorder and remove unused imports in multiple files

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    392be8a View commit details
    Browse the repository at this point in the history

  13. add return type to setters and add() method in MiddlewareRunner

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    021518f View commit details
    Browse the repository at this point in the history

  14. use bindTo() synthax instead of Closure::bind()

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    6fe1b98 View commit details
    Browse the repository at this point in the history

  15. Merge branch '4.x' of https://github.com/slimphp/Slim into Middleware

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    45adef9 View commit details
    Browse the repository at this point in the history

  16. remove unused statement in HttpUnauthorizedExceptionTest

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    fac6cd6 View commit details
    Browse the repository at this point in the history

  17. add closure support in DeferredResolutionMiddleware

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    e57573f View commit details
    Browse the repository at this point in the history

  18. refactor container declaration synthax order in AppTest

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    e615860 View commit details
    Browse the repository at this point in the history

  19. clean up App::group() and type hint Router::popGroup()

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    aa477c4 View commit details
    Browse the repository at this point in the history

  20. fix README typo

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    1737872 View commit details
    Browse the repository at this point in the history

  21. add missing type hints to Route methods and rename variable assignmen… 

    …ts in process()
    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    b349bb4 View commit details
    Browse the repository at this point in the history

  22. fix spelling mistake in doc block in RequestHandler invocation strategy

    @l0gicgate
    l0gicgate committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    5dfaeb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. reorder methods in Routable

    @l0gicgate
    l0gicgate committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    42c3d17 View commit details
    Browse the repository at this point in the history

  2. refactor multiple CallableResolverTest test cases

    @l0gicgate
    l0gicgate committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    0fc5487 View commit details
    Browse the repository at this point in the history

  3. fix PHPCS error

    @l0gicgate
    l0gicgate committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    c452f0b View commit details
    Browse the repository at this point in the history

  4. broaden callable support in DeferredResolutionMiddleware and add supp… 

    …orting tests
    @l0gicgate
    l0gicgate committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ae18cf2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. remove superfluous callable invocation in CallableResolverTest::testC… 

    …losure()
    @l0gicgate
    l0gicgate committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    f5ed7b5 View commit details
    Browse the repository at this point in the history

  2. Reverse logic in ternary to remove negative test

    @akrabat
    akrabat committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    6f7f77a View commit details
    Browse the repository at this point in the history

  3. Remove unneeded temporary variable in DispatchMiddleware

    @akrabat
    akrabat committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    357beb2 View commit details
    Browse the repository at this point in the history

  4. Always uses MiddlewareRunner::add() to add middleware 

    This means that we use PHP 7's type checking and don't need to do it in
the loop on run.
    @akrabat
    akrabat committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    5e8fc67 View commit details
    Browse the repository at this point in the history

  5. Change Route::__construct()'s $methods parameter to always be an array

    @akrabat
    akrabat committed Feb 22, 2019
    1 Configuration menu
    Copy the full SHA
    4bf9785 View commit details
    Browse the repository at this point in the history

  6. Remove redundant conditional

    @akrabat
    akrabat committed Feb 22, 2019
    1 Configuration menu
    Copy the full SHA
    9aa8c6b View commit details
    Browse the repository at this point in the history