Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface #2622

Merged
merged 21 commits into from
Apr 17, 2019
Merged

4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface #2622

merged 21 commits into from
Apr 17, 2019

Conversation

l0gicgate
Copy link
Member

@l0gicgate l0gicgate commented Apr 2, 2019 •
edited

This is pull 2 out of 7 to complete the goals set in #2604

  • Split RouterInterface into RouteCollectorInterface and RouteResolverInterface

  • Rename RouteDispatcher to RouteRunner

  • Move all routing components into new Slim\Routing aggregate folder

  • Discussion

  • Write Tests

@l0gicgate l0gicgate added this to the 4.0 milestone Apr 2, 2019
@l0gicgate l0gicgate requested a review from akrabat April 2, 2019 19:02
@l0gicgate l0gicgate mentioned this pull request Apr 2, 2019
Closed
7 tasks
@akrabat
Copy link
Member

akrabat commented Apr 8, 2019

Should the namespace be Slim\Router ?

@l0gicgate
Copy link
Member Author

Should the namespace be Slim\Router ?

I think Slim\Routing is better imo. A router would be a single component, routing is synonymous of all the components being used.

@akrabat
Copy link
Member

akrabat commented Apr 8, 2019

I think Slim\Routing is better imo. A router would be a single component, routing is synonymous of all the components being used.

The combination of the classes is the router. I don't care enough though, so Routing it is unless someone else has a compelling opinion.

@l0gicgate l0gicgate changed the title [DRAFT] 4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface 4.x - Split RouterInterface into RouteCollectorInterface and RouteResolverInterface Apr 10, 2019
@l0gicgate l0gicgate marked this pull request as ready for review April 10, 2019 06:00
@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited

Coverage Status

Coverage increased (+0.03%) to 98.512% when pulling fd90436 on l0gicgate:4.x-SplitRouter into 821d563 on slimphp:4.x.

akrabat
akrabat reviewed Apr 17, 2019
View reviewed changes
Slim/App.php Outdated Show resolved Hide resolved
@akrabat akrabat merged commit fd90436 into slimphp:4.x Apr 17, 2019
akrabat added a commit that referenced this pull request Apr 17, 2019
@akrabat
Merge branch 'l0gicgate/4.x-SplitRouter' into 4.x
8e07064 
Closes #2622
@l0gicgate l0gicgate deleted the 4.x-SplitRouter branch April 20, 2019 18:09
@l0gicgate l0gicgate mentioned this pull request Apr 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@l0gicgate @akrabat @coveralls