4.x - Add setLogErrorRenderer() to ErrorHandler #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
reviewed
Aug 13, 2019
|
The logic looks good to me. We should add unit tests. |
|
@adriansuter definitely. @RyanNerd do you need help with writing the tests? |
|
@l0gicgate I need to find some time to write the unit tests. Things got busy for me. I'll see if I can get something out there in the next 7 days. |
|
@RyanNerd okay no problem. I might just get antsy and write the tests for you if I have 5 mins 😂 |
l0gicgate
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review. If the logic looks good I'll add unit tests for this feature.
Closes #2797