-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render errors uniformly #2896
Render errors uniformly #2896
Conversation
This is great, thank you for this contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks. Only two minor issues.
Travis fails because of |
This PR is good to go. We just need to wait for #2901 to merge |
@adriansuter we could prophesize the tests also instead of using mockbuilder for uniformity. We have time since we have to wait anyway. What do you think? I or you can do it since he probably doesn't know how to |
@l0gicgate Why not, uniformity is always a good thing. I think we will have plenty of time indeed - and then there is also Christmas and New Year coming. Feel free to prophesize the mocks. |
* Render error uniformly in different formats * Render http exceptions as custom error pages * Hide backtraces in plain format too
I'm locking Prophecy version to 1.9 and merging this. We will address issue in #2901. Won't release 4.4.0 until that's resolved. |
In this PR solved several problems