Strict empty string content type checking in BodyParsingMiddleware::getMediaType #2958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Slim\Middleware\BodyParsingMiddleware::getMediaType()
method has a loose comparison operator, which can make the function return(string) 0
when the requestcontent-type
header has a value of(string) 0
. This is because PHP considers0 == ''
.While this is unhighlike unlikely that it will lead to a bug, because the body parsers need to be registered by the
content-type
header values, the===
seems the accurate one to use to reduce this unexpected execution.