Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the routing results to its own function. #2978

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

dlundgren
Copy link
Contributor

This allows the core logic of the RoutingMiddleware to be extended, without having to copy & paste the core logic.

@coveralls
Copy link

coveralls commented Jun 30, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 14cbc75 on dlundgren:split-resolve-routing into 61093d9 on slimphp:4.x.

Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriansuter I don't foresee any breaking changes with this. Would you mind having a look when you have a minute?

Slim/Middleware/RoutingMiddleware.php Outdated Show resolved Hide resolved
@l0gicgate l0gicgate added this to the 4.6.0 milestone Jul 1, 2020
@l0gicgate l0gicgate merged commit 5f017b0 into slimphp:4.x Jul 1, 2020
@l0gicgate
Copy link
Member

Thank you for your contribution @dlundgren!

@l0gicgate l0gicgate mentioned this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants