Fix: FastRoute dispatcher and data generator should match #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastRoute has recently changed the default dispatcher to MarkBased, and we're based on GroupCountBased. The data generator should always match the dispatcher, so the data generator must be explicitly given to avoid breaking with future FastRoute releases.
|
@edudobay great catch! Let's get this one into the 4.7 release. Thank you! |
l0gicgate
approved these changes
Nov 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing with the
masterbranch of FastRoute, I found the following issue:FastRoute has recently changed the default dispatcher to MarkBased, and Slim is based on GroupCountBased. The data generator should always match the dispatcher, so the data generator must be explicitly given to avoid breaking with future FastRoute releases.