Allow ^1.0 || ^2.0 in psr/container #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do this on all the other repos as well. Thank you for your contribution @Ayesh |
l0gicgate
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIG released a new version of
psr/containertoday. The new 2.x series has parameter types and return types, but it does not remove any methods.Technically, we are compatible with any
psr/container ^1.0 || ^2.0implementation. This PR updates the requiredpsr/containerversions to include 2.x as well, so users can use anypsr/containerimplementation, including ones that implement the new version.I use my own container implementation with
phpwatch/simple-container, that just tagged 2.0.0 withpsr/container ^2.0requirement. I think other containers will follow suit in coming weeks.Thank you.