Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-17 factory from Guzzle/psr7 2.0 #3106

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Use PSR-17 factory from Guzzle/psr7 2.0 #3106

merged 1 commit into from
Aug 19, 2021

Conversation

t0mmy742
Copy link
Contributor

http-interop/http-factory-guzzle recommends to use PSR-17 implementation from guzzlehttp/psr7 if we can use version ^2.0. Since it matches our dependencies, I replaced old package with the new one.
Users can still use http-interop/http-factory-guzzle if they add it manually.

Closes #3105

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 45607c9 on t0mmy742:support_guzzle_psr17_2_0 into c431514 on slimphp:4.x.

@l0gicgate
Copy link
Member

This shouldn’t break any downstream projects since they would already have Guzzle PSR-7 which includes the Psr17 factories correct?

@l0gicgate l0gicgate added this to the 4.9.0 milestone Aug 19, 2021
@l0gicgate l0gicgate merged commit b9b6339 into slimphp:4.x Aug 19, 2021
@t0mmy742
Copy link
Contributor Author

@l0gicgate Since we dropped support for guzzlehttp/psr7:^1.0 and updated to ^2.0, people using this PSR-7 provider already have PSR-17 factory.
If keeping http-interop/http-factory-guzzle is something wanted, people already installed it manually since it's not in our requirement packages.
TODO: We should update README file to specify version of supported PSR-7 providers.

@t0mmy742 t0mmy742 deleted the support_guzzle_psr17_2_0 branch August 21, 2021 12:51
@ArrayIterator
Copy link

On version (current / 4.8.1 release) not yet update.

protected static $responseFactoryClass = 'Http\Factory\Guzzle\ResponseFactory';

Any info about released from current master?

@l0gicgate l0gicgate mentioned this pull request Oct 5, 2021
@l0gicgate
Copy link
Member

@ArrayIterator just release 4.9.0 which features the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PSR-17 implementation from Guzzle/psr7 2.0
4 participants