Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding property type declarations for Factory classes #3196

Merged
merged 6 commits into from
May 5, 2022
Merged

Adding property type declarations for Factory classes #3196

merged 6 commits into from
May 5, 2022

Conversation

ashleycoles
Copy link
Contributor

Added type declarations for all properties in Slim\Factory classes excluding a union in ServerRequestCreator to preserve php7.4 compatibility

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.892% when pulling 4a154f5 on ashleycoles:factoryTypes into 40b854c on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.11.0 milestone May 5, 2022
l0gicgate
l0gicgate approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @ashleycoles!

@l0gicgate l0gicgate merged commit ebc1602 into slimphp:4.x May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

@nbayramberdiyev nbayramberdiyev nbayramberdiyev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashleycoles @coveralls @l0gicgate @nbayramberdiyev