Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant docblock types #3197

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Remove redundant docblock types #3197

merged 4 commits into from
Jun 1, 2022

Conversation

theodorejb
Copy link
Contributor

This will make it easier to read and refactor the code going forward.

Also added a couple missing property types and removed a redundant null check.

@theodorejb
Remove redundant docblock types
0305b2a 
This will make it easier to read and refactor the code going forward.
@theodorejb
Remove redundant condition
ebc0814
@coveralls
Copy link

coveralls commented May 8, 2022 •
edited

Coverage Status

Coverage increased (+0.0002%) to 99.892% when pulling abc7f56 on theodorejb:type-cleanup into 6ff5bf4 on slimphp:4.x.

l0gicgate
l0gicgate approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution

@l0gicgate l0gicgate added this to the 4.11.0 milestone Jun 1, 2022
@l0gicgate l0gicgate merged commit fa54362 into slimphp:4.x Jun 1, 2022
@theodorejb theodorejb deleted the type-cleanup branch June 1, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theodorejb @coveralls @l0gicgate