Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated methods as of Twig 2.7 #104

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Replace deprecated methods as of Twig 2.7 #104

merged 2 commits into from
Apr 6, 2019

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Mar 13, 2019

No description provided.

@jmarsman
Copy link

+1

@Saeufer
Copy link

Saeufer commented Mar 19, 2019

+2

@ghost
Copy link

ghost commented Mar 19, 2019

The composer.json must also be updated because there were no namespaces in Twig 1.18.

@trasher
Copy link
Contributor Author

trasher commented Mar 20, 2019

@tino-codes indeed you are right. Do you now in which version this has been added? Dunno if requiring Twig 2.0 minimum would be ok for Twig-View

@ghost
Copy link

ghost commented Mar 20, 2019

https://github.com/twigphp/Twig/blob/2.x/CHANGELOG

2.7.0 (2019-03-12)

  • deprecated PSR-0 classes in favor of namespaced ones
  • made namespace classes the default classes (PSR-0 ones are aliases now)

https://github.com/twigphp/Twig/blob/1.x/CHANGELOG

1.38.0 (2019-03-12)

  • made namespace classes the default classes (PSR-0 ones are aliases now)

@trasher
Copy link
Contributor Author

trasher commented Mar 20, 2019

Thank you very much :)

@mbolli
Copy link
Contributor

mbolli commented Mar 25, 2019

Please merge this asap...

@trasher trasher mentioned this pull request Mar 25, 2019
Closed
@cedric-anne
Copy link

👍

@cocochepeau
Copy link

FYI: https://security-tracker.debian.org/tracker/CVE-2019-9942

trasher added a commit to trasher/glpi that referenced this pull request Apr 3, 2019
@trasher
Locally apply proposed patch
a74bada 
See slimphp/Twig-View#104
@trasher trasher mentioned this pull request Apr 3, 2019
Merged
trasher added a commit to glpi-project/glpi that referenced this pull request Apr 3, 2019
@trasher
Locally apply proposed patch
523cab7 
See slimphp/Twig-View#104
@akrabat akrabat modified the milestones: 2.4.0, 2.5.0 Apr 6, 2019
@akrabat akrabat merged commit bb74df5 into slimphp:master Apr 6, 2019
akrabat added a commit that referenced this pull request Apr 6, 2019
@akrabat
Merge branch 'twig-27-deprecateds'
7cb5289 
Closes #104
@akrabat
Copy link
Member

akrabat commented Apr 6, 2019

Version 2.5.0 released.

@ntzm
Copy link

ntzm commented Apr 7, 2019

Thanks @akrabat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntzm ntzm ntzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
8 participants
@trasher @jmarsman @Saeufer @mbolli @cedric-anne @cocochepeau @akrabat @ntzm