Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow direct insert #411

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

yokofly
Copy link
Contributor

@yokofly yokofly commented Oct 21, 2024

try fix #35 previous we work in #404 now here.
usage: export SLING_ALLOW_DIRECT_INSERT=true
current if we stop the insert to the target table, the rollback will do nothing, because the target table is directly inserted.

latest code 2 issues

  1. the column change, previous we have upsert to handle some column type incorrectly but still can be inserted from temp table to target, but now we do not have such a guard. so we need adjust column type directly from target if there is?(ideally we shall tell the user to create target table first by themselves?)

  2. the stream written count and the target table count. we shall find a more better way to comparison OR lower the err level to just logging instead of stopping the transfer. because in some cases we wrote ZERO count and the target table count is unrelated to this new insert.

@flarco flarco merged commit e7486ac into slingdata-io:v1.2.22 Oct 24, 2024
@flarco
Copy link
Collaborator

flarco commented Oct 24, 2024

Will work on branch v1.2.22, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants