Skip to content

Commit

Permalink
Don't force inlining if there is a @children
Browse files Browse the repository at this point in the history
We should only force inlining if there is children. The presence of a
`@children` or not shouldn't matter
  • Loading branch information
ogoffart committed Jul 3, 2024
1 parent 40cabb8 commit 8117e9b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions internal/compiler/passes/inlining.rs
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,6 @@ fn duplicate_transition(
// Some components need to be inlined to avoid increased complexity in handling them
// in the code generators and subsequent passes.
fn component_requires_inlining(component: &Rc<Component>) -> bool {
if component.child_insertion_point.borrow().is_some() {
return true;
}

let root_element = &component.root_element;
if super::flickable::is_flickable_element(root_element)
|| super::lower_layout::is_layout_element(root_element)
Expand Down

0 comments on commit 8117e9b

Please sign in to comment.