Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt renderer: Fix drawing of the border rectangle with non-opaque borders #2079

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Qt renderer: Fix drawing of the border rectangle with non-opaque borders #2079

merged 2 commits into from
Jan 18, 2023

Conversation

ogoffart
Copy link
Member

Also fix the border radius to be the outer radius of the rectangle

Qt renderer part of #1988 (minus clipping)

@ogoffart
Qt backend: Fix drawing of the border rectangle with non-opaque borders
b33941c 
Also fix the border radius to be the outer radius of the rectangle

Qt renderer part of #1988  (minus clipping)
@ogoffart ogoffart marked this pull request as ready for review January 18, 2023 10:44
tronical
tronical approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

internal/backends/qt/qt_window.rs Outdated Show resolved Hide resolved
@tronical
Copy link
Member

For the PR title (as used for weekly) I suggest to s/backend/renderer/

ogoffart
ogoffart commented Jan 18, 2023
View reviewed changes
internal/backends/qt/qt_window.rs Outdated Show resolved Hide resolved
internal/backends/qt/qt_window.rs Outdated Show resolved Hide resolved
@ogoffart @tronical
Apply suggestions from code review
d90f669 
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
@ogoffart ogoffart merged commit 4bc7571 into master Jan 18, 2023
@ogoffart ogoffart deleted the olivier/qt-rectangle branch January 18, 2023 13:05
@ogoffart ogoffart changed the title Qt backend: Fix drawing of the border rectangle with non-opaque borders Qt renderer: Fix drawing of the border rectangle with non-opaque borders Jan 18, 2023
tronical added a commit that referenced this pull request Jan 19, 2023
@tronical
Fix FemtoVG's drawing of the border rectangle with non-opaque borders (…
47a6803 
…#2079)

Also fix the border radius to be the outer radius of the rectangle

FemtoVG renderer part of #1988 (minus clipping)
tronical added a commit that referenced this pull request Jan 19, 2023
@tronical
Fix FemtoVG's drawing of the border rectangle with non-opaque borders (…
7331a43 
…#2079)

Also fix the border radius to be the outer radius of the rectangle

FemtoVG renderer part of #1988 (minus clipping)
tronical added a commit that referenced this pull request Jan 19, 2023
@tronical
Fix FemtoVG's drawing of the border rectangle with non-opaque borders (…
911d0e4 
…#2079)

Also fix the border radius to be the outer radius of the rectangle

FemtoVG renderer part of #1988 (minus clipping)
tronical added a commit that referenced this pull request Jan 19, 2023
@tronical
Fix Skia's drawing of the border rectangle with non-opaque borders (#…
bdf1de1 
…2079)

Also fix the border radius to be the outer radius of the rectangle

Skia renderer part of #1988 (minus clipping)
tronical added a commit that referenced this pull request Jan 20, 2023
@tronical
Fix Skia's drawing of the border rectangle with non-opaque borders (#…
b2c0392 
…2079) (#2086)

Also fix the border radius to be the outer radius of the rectangle

Skia renderer part of #1988 (minus clipping)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogoffart @tronical