-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Todo demo: implement the dialog as a separate window #2094
base: master
Are you sure you want to change the base?
Conversation
Only the Rust part is in this PR, the dialog is still in the todo.slint because of the C++ |
(The problem with this approach is that there is no "modality" concept or window parenting relationship) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the lack of modality, I think this is a good improvement. I'm in favor.
import { StandardButton } from "std-widgets.slint"; | ||
|
||
component ConfirmDialog inherits Dialog { | ||
confirm_popup_text := Text { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm_popup_text := Text { | |
Text { |
I've had rebased this change on (and btw, on latest Compare to this change rebased on 3deb620: While playing around with the todo example I noticed it is also suffering from exceptionally long compile times. This simple app with rather minimal Slint code is taking over 2 minutes to compile on my system! The Rust compiler has to process 15300 lines of generated Rust code... (I've pushed the rebased patch to bjorn@2504b9f) |
No description provided.