Fix timer not firing on Windows #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Nov 7, 2023
No this is wrong. the default on windows is whatever was set last.
It works because the patch is wrong, and with this we would never wait. I think the bug is really in winit |
On Windows, winit doesn't respect the set_control_flow from the AboutToWait event. This is a bug in winit, but we can easily work it around Fix #3875
ogoffart
force-pushed
the
olivier/fix-3875
branch
from
a88737a
to
064d634
Compare
|
Made a new patch |
tronical
approved these changes
Nov 7, 2023
|
rust-windowing/winit#3216 was merged. But I'll merge this as well so we have a fix for the release. Will revert once next version of winit is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set the control flow to Wait, winit will always wait even if we set the control flow later to some smaller timeout in the AboutToWait event.
Wait is the default anyway in winit 0.29 so this is not required
I'd say this is a bug in winit, but we can easily work it around
Fix #3875