LSP preview: fix some issue related to geometry #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ogoffart
commented
Dec 28, 2023
ogoffart
commented
- make sure that the initial size is proper by calling show() on the preview ui after the factory has been set
- ensure that there is no recursion if the inner layout info depends on the size (Fixes LSP crash when specifying padding based on parent width #3989)
- Ensure that the geometry constraints are respected when previewing a component that was already resized
- make sure that the initial size is proper by calling show() on the preview ui after the factory has been set - ensure that there is no recursion if the inner layout info depends on the size (Fixes #3989) - Ensure that the geometry constraints are respected when previewing a component that was already resized
tronical
approved these changes
Jan 2, 2024
Comment on lines
+135
to
+140
| if i-preview-area-container.has-component && root.preview-area == i-preview-area-container.component-factory : Rectangle { | ||
| init => { | ||
| i-preview-area-container.width = clamp(i-preview-area-container.width, i-preview-area-container.min-width, i-preview-area-container.max-width); | ||
| i-preview-area-container.height = clamp(i-preview-area-container.height, i-preview-area-container.min-height, i-preview-area-container.max-height); | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess in the future we can do this with a changed callback? (property <bool> condition: ...; changed condition => { ... })
There was a problem hiding this comment.
yes, if we had changed callback we couldn't need that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.