-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acessibility: added AccessibilityAction and SupportedAccessibilityAction #4824
Acessibility: added AccessibilityAction and SupportedAccessibilityAction #4824
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I share this sentiment. Perhaps we should just declare the ones we know are trivial to implement at this point and then add more later. That's basically Focus, Increment, Decrement, SetValue, SetTextSelection, SetValue, and perhaps ReplaceSelectedText. Maybe there are more? |
internal/core/accessibility.rs
Outdated
pub enum AccessibilityAction { | ||
Default, | ||
Focus, | ||
Blur, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what the expected behaviour here is. I wonder how to trigger this.
Agree. Make it easier to implement and the whole thing. And additional features can be extended later. |
I don't think we should merge this as is in master, because there is no use for it without the code that uses it. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Ok I can do a general wip/accessibility branch and we can merge it there. @ogoffart what do you think? |
Good idea. If you call it |
done. I have also change this PR from master to the feature/accessibility branch. |
The adds only the enums / structs needed to implement accessibility actions. There is no functionality yet. This is the first step to implement #2872. The enum is a copy of the available accessibility actions provides by accesskit, before merging we need to check what is really needed for Slint and can be already implemented with the current feature set.