Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acessibility: added AccessibilityAction and SupportedAccessibilityAction #4824

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

FloVanGH
Copy link
Member

The adds only the enums / structs needed to implement accessibility actions. There is no functionality yet. This is the first step to implement #2872. The enum is a copy of the available accessibility actions provides by accesskit, before merging we need to check what is really needed for Slint and can be already implemented with the current feature set.

internal/core/accessibility.rs Outdated Show resolved Hide resolved
internal/core/accessibility.rs Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@FloVanGH FloVanGH marked this pull request as ready for review March 13, 2024 07:36
@tronical
Copy link
Member

... before merging we need to check what is really needed for Slint and can be already implemented with the current feature set.

I share this sentiment. Perhaps we should just declare the ones we know are trivial to implement at this point and then add more later. That's basically Focus, Increment, Decrement, SetValue, SetTextSelection, SetValue, and perhaps ReplaceSelectedText. Maybe there are more?

pub enum AccessibilityAction {
Default,
Focus,
Blur,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the expected behaviour here is. I wonder how to trigger this.

@FloVanGH
Copy link
Member Author

... before merging we need to check what is really needed for Slint and can be already implemented with the current feature set.

I share this sentiment. Perhaps we should just declare the ones we know are trivial to implement at this point and then add more later. That's basically Focus, Increment, Decrement, SetValue, SetTextSelection, SetValue, and perhaps ReplaceSelectedText. Maybe there are more?

Agree. Make it easier to implement and the whole thing. And additional features can be extended later.

@ogoffart
Copy link
Member

I don't think we should merge this as is in master, because there is no use for it without the code that uses it.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@FloVanGH
Copy link
Member Author

I don't think we should merge this as is in master, because there is no use for it without the code that uses it.

Ok I can do a general wip/accessibility branch and we can merge it there. @ogoffart what do you think?

@tronical
Copy link
Member

Good idea. If you call it feature/accessibility then it'll automatically CI tested (if you'd like that).

@FloVanGH FloVanGH changed the base branch from master to feature/accessibility March 15, 2024 08:02
@FloVanGH
Copy link
Member Author

Good idea. If you call it feature/accessibility then it'll automatically CI tested (if you'd like that).

done. I have also change this PR from master to the feature/accessibility branch.

@FloVanGH FloVanGH merged commit 737ac93 into feature/accessibility Mar 15, 2024
36 checks passed
@FloVanGH FloVanGH deleted the florian/accessability-runtime-1 branch March 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants