Change callback experimental implementation. #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,20 @@ | |||
| // Copyright © SixtyFPS GmbH <info@slint.dev> | |||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial | |||
There was a problem hiding this comment.
[xtask license_header] reported by reviewdog 🐶
Suggested change
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial | |
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.2 OR LicenseRef-Slint-commercial |
Comment on lines
1
to
2
| // Copyright © SixtyFPS GmbH <info@slint-ui.com> | ||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-commercial |
There was a problem hiding this comment.
[xtask license_header] reported by reviewdog 🐶
Suggested change
| // Copyright © SixtyFPS GmbH <info@slint-ui.com> | |
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-commercial | |
| // Copyright © SixtyFPS GmbH <info@slint.dev> | |
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.2 OR LicenseRef-Slint-commercial |
tests/cases/properties/changes.slint
Outdated
| @@ -0,0 +1,73 @@ | |||
| // Copyright © SixtyFPS GmbH <info@slint.dev> | |||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial | |||
There was a problem hiding this comment.
[xtask license_header] reported by reviewdog 🐶
Suggested change
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial | |
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.2 OR LicenseRef-Slint-commercial |
Introduce a ChangeTracker type, but it is not of any use now
ogoffart
force-pushed
the
olivier/changed-callbacks
branch
from
ad28cc7
to
9e9ab89
Compare
ogoffart
force-pushed
the
olivier/changed-callbacks
branch
from
44d7509
to
2604064
Compare
ogoffart
force-pushed
the
olivier/changed-callbacks
branch
from
2604064
to
fbe96a7
Compare
tronical
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gated by the experimental feature gate.
CC #112
We can already use that internally and try to get more experience.
But we still need to document, and define all edge cases and test them properly.
(what happens with loops, order of evaluation, when is the first callback called)