Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBox reset current on model changed #5217

Merged
merged 5 commits into from
May 15, 2024
Merged

ComboBox reset current on model changed #5217

merged 5 commits into from
May 15, 2024

Commits on May 15, 2024

  1. ComboBox reset current on model changed

    @FloVanGH
    FloVanGH committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2e2b47d View commit details
    Browse the repository at this point in the history

  2. Fix unused property removal pass not deleting change callbacks 

    When eliminating a properyt, also make sure to remove associated change callbacks:

```slint
export component Testcase {
    t := Rectangle {
        in-out property <int> index: 0;
        changed index => {
        }
    }
}
```
    @tronical @FloVanGH
    tronical authored and FloVanGH committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4c0c17c View commit details
    Browse the repository at this point in the history

  3. Fix change callbacks on renamed aliases 

    When an observed property is renamed due to alias removal, make sure to update the name of the observed property:

```slint
export component Testcase {
    in-out property index <=> t.index;
    t := Rectangle {
        in-out property <int> index: 0;
        changed index => {
        }
    }
}
```
    @tronical @FloVanGH
    tronical authored and FloVanGH committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6b63647 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @FloVanGH
    FloVanGH committed May 15, 2024
    Configuration menu
    Copy the full SHA
    282f3db View commit details
    Browse the repository at this point in the history

  5. changelog update

    @FloVanGH
    FloVanGH committed May 15, 2024
    Configuration menu
    Copy the full SHA
    77e318e View commit details
    Browse the repository at this point in the history