Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the C++ testing API in the C++ API docs #5398

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tronical
Copy link
Member

No description provided.

@tronical tronical requested a review from ogoffart June 13, 2024 08:42
@tronical
Copy link
Member Author

This adds the testing API, but the AccessibleRole is still not documented. It needs to go into a public header file, otherwise doxygen won't look at it. I think I'll try to hack it that it goes into slint::testing inside slint_enums.h.

@ogoffart
Copy link
Member

Should we wait until this is no longer experimental perhaps?
Or is there a way to mark it as such?

@tronical
Copy link
Member Author

I don't have a strong opinion on this, but if we every want to ask folks for feedback on an API, I think it makes sense that they have API documentation to read to learn how to use it... (yes, we should also do that for slint-esp).

We could document that in the testing namespace, that it's experimental. Or have everything under slint::experimental:: (so slint::experimental::testing:...).

api/cpp/cbindgen.rs Outdated Show resolved Hide resolved
@ogoffart
Copy link
Member

Having it under slint::experimental:: is an option, but it is more complicated than just adding an #ifdef as then we will have to search and replace once we move it out of experimental

@tronical
Copy link
Member Author

Yep, I also don't like slint::experimental. Ok, I'll add a bit comment for the docs for the slint::testing namespace it's conditional - better than nothing IMO and good to have docs for this API (the doc building also helps us find issues).

@tronical
Copy link
Member Author

What do you think about this compromise?

(One caveat here is that while the AccessibleRole is now under slint::testing, it's not surrounded by #ifdefs, but maybe that's an acceptable corner?)

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it needs some bold or more visible warning.

@tronical
Copy link
Member Author

Alternate idea: We include the docs for experimental APIs in the nightly docs, but not in the releases. What do you think?

@ogoffart
Copy link
Member

Alternate idea: We include the docs for experimental APIs in the nightly docs, but not in the releases. What do you think?

I like this idea very much!

(although that means that the snapshot is not an exact preview of the release, but that's fine)

@tronical tronical merged commit bda89c2 into master Jul 11, 2024
0 of 24 checks passed
@tronical tronical deleted the simon/cppdocs-experimental branch July 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants