API Review: Remove suspend/resume related functions from FemtoVG renderer #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Jul 7, 2024
…erer This could've been `set_opengl_context` taking an `Option`, but it turns out that makes for an awkward interface when wanting to pass None, because that also then requires a dummy type for the OpenGL context even though none is wanted.
tronical
force-pushed
the
simon/femtovg-cleanup
branch
from
7cb05b2
to
e8d9df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could've been
set_opengl_contexttaking anOption, but it turns out that makes for an awkward interface when wanting to pass None, because that also then requires a dummy type for the OpenGL context even though none is wanted.