Made ComboBox scrollable #5581
Made ComboBox scrollable #5581
Conversation
| callback selected <=> i-base.selected; | ||
| callback selected <=> base.selected; | ||
|
|
||
| property <length> item-height: 40px; |
There was a problem hiding this comment.
Can this really be hardcoded like this? Where does the value comes from?
There was a problem hiding this comment.
@ogoffart it comes from the fluent style. Yeah problem is I didn't find a way to get the height but I need it for the popup height calculation. Because sooner or later the qt style will be deleted I thought it's ok for now. If not just let me know, and maybe you know how to get the height.
I think until we have a way to place the popup depending on available width / height of e.g. window or parent we should not allow the combobox height to be to big, because it will end up in more situations someone mentions that the combobox popup is cut off. Or what do you think? |
There was a problem hiding this comment.
Yes indeed, we need to place the popup window differently if it is at the bottom of the screen.
This is complicated logic that needs support in the runtime and improvement to the PopupWindow which is unfortunately out of scope for the upcoming release.
I still think 5 is a bit small though, i'd prefer if it was a bit more.
And I'm not happy about the hardcoded size in the Qt style at all. You could get the size through NativeStyleMetrics perhaps. Anyway, i get your point that you don't like to touch this style too much.
Given that this is clearly an improvements for the other styles (as opposed to have the menu half clipped) i think we should merge this with a bit more elements visible and not set the height to the hardcoded size in the Qt style.
|
|
||
| for value[index] in root.model: NativeStandardListViewItem { | ||
| item: { text: value }; | ||
| is-selected: root.current-index == index; | ||
| has-hover: ta.has-hover; | ||
| combobox: true; | ||
| height: root.item-height; |
There was a problem hiding this comment.
Even if we hardcode the size for the purpose of computing the maximum height, we shouldn't hardcode the size here.
There was a problem hiding this comment.
@ogoffart yes I know. It I also prefer not to set hard coded with / height. But in this case I'm not able to determine the viewport-height because of again the restriction of accessing stuff inside of the PopupWindow. So without hardcoded height it is not possible at the moment to implement the grow behavior for the ComboBox's Popup. Alternative would be to give the popup a fixed height.
|
With #5584 merged, it is now possible to position based on the size. |
@ogoffart it also does not fix the need of hardcoded size. The problem is not only the placement of the popup it is also to stretch the popup depending on count of displayed items. Alternative would be a fixed height for the Popup what it's also ok I think. |
|
I think a hardcoded maximum size would be a good workaround for now. (without fixing the size of the |
FloVanGH
force-pushed
the
florian/cb-scroll
branch
from
403d382
to
d83b503
Compare
Fixes #4727