Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic accessibility tree updates not working in the interpreter #5603

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

tronical
Copy link
Member

It turns out that for repeated elements, we set root_weak to self_weak, instead of the root we obtain from the parent instance. Fix this by moving the code to initialize parent_item_tree_offset to before we try to use it (via parent_instance) to initialize root_weak.

It turns out that for repeated elements, we set root_weak to self_weak, instead of the root we obtain from the parent instance. Fix this by moving the code to initialize parent_item_tree_offset to before we try to use it (via parent_instance) to initialize root_weak.
@tronical tronical force-pushed the simon/interpreter-accessibility branch from 460cd30 to 4956e36 Compare July 11, 2024 13:18
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interresting that only accessibility broke. Is nothing else using the root_weak?

@tronical
Copy link
Member Author

I suppose like many other places, we just silently skip. Like in the accessibility case, we just didn't end up calling unregister_item_tree because of self.root_weak().upgrade()?;

@tronical
Copy link
Member Author

But indeed, there are only three call sites for maybe_window_adapter. One in instantiate (that always works), one in Drop (this one didn't), and one in the ffi, called from the C++ interpreter API I suppose.

@tronical tronical merged commit c74872a into master Jul 11, 2024
38 checks passed
@tronical tronical deleted the simon/interpreter-accessibility branch July 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants