Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Design Review fixes for library, properties and preview #5604

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Editor: Design Review fixes for library, properties and preview #5604

merged 3 commits into from
Jul 11, 2024

Conversation

FloVanGH
Copy link
Member

@FloVanGH FloVanGH commented Jul 11, 2024 •
edited

  • Cleanup file structure
  • Visual Cleanup Library
  • Visual Cleanup Preview
  • Visual Cleanup Properties

Notes

  • at the moment the complete library is reloaded after changes on the preview, this causes that current scroll position and open states of header items are get lost and resets to default. (will be fixed)
  • Help me to test that everything works as expected
  • For the release it should be good now. After release I would like spent time to refactor the properties.

image

@FloVanGH FloVanGH requested a review from hunger July 11, 2024 13:42
hunger
hunger approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@hunger hunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer!

hunger
hunger reviewed Jul 11, 2024
View reviewed changes
.reuse/dep5 Outdated Show resolved Hide resolved
@FloVanGH FloVanGH merged commit f32bec3 into master Jul 11, 2024
38 checks passed
@FloVanGH FloVanGH deleted the florian/editor-component-list branch July 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunger hunger hunger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FloVanGH @hunger