Revert "Remove extra vertical spacing between the header view and the… #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library/preview/property." This reverts commit a4ce75d, maintains the margin, but fixes the background color to patch the header.
|
Before either change: After the initial change: With this change applied: 
|
|
👎 the toolbar is not aligned verticaly |
|
Can you elaborate how this patch affects vertical alignment? |
|
Ahh, I guess you mean the space above "Style", "Interact", etc. and the space below towards the three "panels". |
|
Yes, I agree, that's misaligned. FWIW, I also prefer a4ce75d. |
|
IMHO that misalignment is the point: You want to separate the toolbar from the main area. I do prefer the first version that @FloVanGH implemented. It has a very nice separation between toolbar and the main area and has pleasant spacing, not cluttering everything into the top right corner. |
|
Florian has something better brewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… library/preview/property."
This reverts commit a4ce75d, maintains the margin, but fixes the background color to patch the header.