Fix rust generated code with struct of percent
value
#5889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wouldn't detect percent as a unit product in
slint/internal/compiler/generator/rust.rs
Lines 2418 to 2422 in 43c7f57
Percent is not strictly of percent unit because that unit doesn't combine with other unit (as per the comment in
default_unit
) But since it converts to number, it is then an unitless value. (scalar)Fixes #5887