Fix locating the slint-compiler.exe on cmake cross-compiled packages #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling CMAKE_EXECUTABLE_SUFFIX may not be set to .exe even though the host is Windows, because this variable always refers to the target. This is a missing feature in cmake, so work around it for now. See also https://gitlab.kitware.com/cmake/cmake/-/issues/17553 I made a similar workaround in Corrosion long time ago with commit b8a6b26a0f2d526e0492df9fd88c0495b0b8a64f The target prop line is duplicated in favor of introducing a variable, that would otherwise be at risk of being visible in the user scope.
ogoffart
approved these changes
Aug 23, 2024
|
Good idea. I’ll research a little and maybe make a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling CMAKE_EXECUTABLE_SUFFIX may not be set to .exe even though the host is Windows, because this variable always refers to the target. This is a missing feature in cmake, so work around it for now. See also https://gitlab.kitware.com/cmake/cmake/-/issues/17553 I made a similar workaround in Corrosion long time ago with commit b8a6b26a0f2d526e0492df9fd88c0495b0b8a64f
The target prop line is duplicated in favor of introducing a variable, that would otherwise be at risk of being visible in the user scope.