live-preview: Remove string value/range from property information #5926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Aug 23, 2024
hunger
force-pushed
the
tobias/push-nnkzssmkmxqx
branch
from
a087fd1
to
a4dd132
Compare
|
The latest changes add some more helper functions found on It also removes the explicit |
Pass the syntax node defining the current property value along with the other information on properties. This will allow us to look at the AST nodes and not just the string value containing the expression.
... by implementing more helpers on `parser::SyntaxNode` and `parser::SyntaxToken`.
hunger
force-pushed
the
tobias/push-nnkzssmkmxqx
branch
from
a4dd132
to
14c2fba
Compare
|
I really need to automate |
ogoffart
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we do no longer need to pass all the property data through the LSP, we can actually pass around the SyntaxNode defining the current property value, so that we do not have to make sense of a string, but can look at the original AST instead.