Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: hover (tooltip) support #5969

Merged
merged 3 commits into from
Aug 28, 2024
Merged

LSP: hover (tooltip) support #5969

merged 3 commits into from
Aug 28, 2024

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Aug 27, 2024

No description provided.

@ogoffart ogoffart requested a review from hunger August 28, 2024 09:32
@ogoffart ogoffart marked this pull request as ready for review August 28, 2024 09:32
from_slint_code(&format!("global {}", c.id))
} else {
from_slint_code(&format!("component {}", c.id))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to find out whether the component is exported or not? That would be interesting information I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a lot of other information that can be added. But my time boxing for this feature is over :-)

We need to find out exported relative to whom.

@ogoffart ogoffart merged commit ee42f96 into master Aug 28, 2024
35 checks passed
@ogoffart ogoffart deleted the olivier/lsp branch August 28, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants