Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arc-swap to v1.0 #12

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Update arc-swap to v1.0 #12

merged 1 commit into from
Jan 12, 2021

Conversation

reyk
Copy link
Contributor

@reyk reyk commented Nov 26, 2020

Update arc-swap to satisfy the dependency tree.

See also slog-rs/atomic#7

Cargo.toml Outdated
@@ -16,7 +16,7 @@ path = "lib.rs"
[dependencies]
slog = "2.4"
lazy_static = "1.2"
arc-swap = "0.4"
arc-swap = "1.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyk how about updating to "1.1" to address RUSTSEC-2020-0091 as well

Suggested change
arc-swap = "1.0"
arc-swap = "1.1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this PR predates the RUSTSEC advisory but never got merged. I can update it.

Copy link

@ddaws ddaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Would be great to get this merged

@koushiro
Copy link

@dpc could you please merge the PR and release a patch version? I don’t want to have duplicate dependencies in the dependency tree of my project.

@dpc dpc merged commit 75e60d7 into slog-rs:master Jan 12, 2021
@dpc
Copy link
Contributor

dpc commented Jan 12, 2021

v4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants