Skip to content

Commit

Permalink
Don't test log/unstable_kv feature on the MSRV
Browse files Browse the repository at this point in the history
Due to its unstable feature, it requires a recent compiler
and we cannot reasonably make MSRV guarentees for their project.

Add disclaimer about this to the Cargo.toml file
  • Loading branch information
Techcable committed Mar 23, 2022
1 parent 7a93747 commit a1886c9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
fail-fast: false # Even if one job fails we still want to see the other ones
matrix:
# 1.39 is MSRV. Keep in sync with Cargo.toml
#
# There are no MSRV guarentees for the kv_unstable feature.
# See `Cargo.toml` for more details.
rust: [1.39, stable, nightly]
# NOTE: Features to test must be specified manually. They are applied to all versions seperately.
#
Expand All @@ -37,6 +40,9 @@ jobs:
#
# Specific feature combos can be overriden per-version with 'include' and 'exclude'
features: ["", "kv_unstable"]
exclude:
- rust: 1.39 # MSRV (see above)
features: "kv_unstable"

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ edition = "2018"
#
# The first version of Cargo that supports this field was in Rust 1.56.0.
# In older releases, the field will be ignored, and Cargo will display a warning.
#
# DISCLAIMER:
# The log/kv_unstable feature requires a recent (stable) compiler.
# It will not compile with this claimed MSRV and requires a recent (stable) compiler.
rust-version = "1.38"

[lib]
Expand Down

0 comments on commit a1886c9

Please sign in to comment.