numeric.T.eig looks suspicious #61
Comments
gagern
added a commit
to CindyJS/CindyJS
that referenced
this issue
Sep 8, 2015
This function looks in part like a class (i.e. static method), and in part like an instance method, but neither makes too much sense as it stands. Reported upstream as sloisel/numeric#61 Will disable the method for now, since it is unusable in its current form. Disabling it gets rid of a bunch of closure compiler warnings.
montaga
pushed a commit
to montaga/CindyJS
that referenced
this issue
Oct 16, 2015
This function looks in part like a class (i.e. static method), and in part like an instance method, but neither makes too much sense as it stands. Reported upstream as sloisel/numeric#61 Will disable the method for now, since it is unusable in its current form. Disabling it gets rid of a bunch of closure compiler warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
numeric.T.eigfunction, as implemented in 610f250, looks suspicious: either it's an instance method, then it belongs intonumeric.T.prototype.eig. But in that case I don't understand its semantics, since you can't reasonably compute eigenvalues of a single complex number. Or it's a class method, then it should not refer tothis. And to make sense semantically, it should probably also take a complex-valued matrix as an argument. I see noone using this function at all, so unless there is actually a use case for this, you might also consider deleting it.The text was updated successfully, but these errors were encountered: