Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a limit of 20 public keys on encryption due to age decryption limits #67

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

slok
Copy link
Owner

@slok slok commented Mar 22, 2021

In order to avoid future undecryptable encrypted files due to Age's 20 recipients limit, we don't allow encrypting with more than 20 recipients.

More information here: FiloSottile/age#139

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@slok
Copy link
Owner Author

slok commented Mar 22, 2021

Codecov Report

Merging #67 (fd70927) into main (95b738e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   80.83%   80.90%   +0.06%     
==========================================
  Files          15       15              
  Lines         819      822       +3     
==========================================
+ Hits          662      665       +3     
  Misses         98       98              
  Partials       59       59              
Impacted Files Coverage Δ
internal/secret/encrypt/age/age.go 63.63% <100.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b738e...fd70927. Read the comment docs.

@slok slok merged commit 90c13ce into main Mar 22, 2021
@slok slok deleted the slok/max-recipients branch March 22, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant