-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple test for Maven builder #253
Conversation
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
c6d3dca
to
fe95490
Compare
e3fb7d5
to
458a9ff
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
458a9ff
to
d82c253
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
add verification
@laurentsimon Could you have a look at the assertions I have added? |
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: AdamKorcz <adam@adalogics.com>
@laurentsimon @ianlewis Please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's wait for final comment from @ianlewis , especially the one on bootstrap
needs.
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: AdamKorcz <adam@adalogics.com>
373f8b1
to
2323009
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
2323009
to
69ff369
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
fix some linters Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
try fix other linter Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@ianlewis take a final look. i think we're ready to merge |
Thanks @laurentsimon! |
I pushed some changes to your branch. Just fyi in case you want to edit the code, don't forget to pull |
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Adds another `input` for the Maven builder to allow the user to specify the project directory. The current problem this solves is to make slsa-framework/example-package#253 work. This was suggested by @laurentsimon in slsa-framework/example-package#253 (comment) --------- Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Signed-off-by: AdamKorcz <adam@adalogics.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Adds a simple test for the Maven builder.
@laurentsimon