Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] Update ref for Maven Action #2508

Closed
laurentsimon opened this issue Aug 1, 2023 · 1 comment · Fixed by #2510
Closed

[release] Update ref for Maven Action #2508

laurentsimon opened this issue Aug 1, 2023 · 1 comment · Fixed by #2510
Labels
area:BYOB An issue with the BYOB framework area:tooling An issue with project tooling and config
Milestone
BYOB framework GA

Comments

@laurentsimon
Copy link
Collaborator

See #2482 (comment)

We need to keep this ref in sync. We need to update the release script for ref update, and the corresponding pre-submits
@laurentsimon laurentsimon added area:tooling An issue with project tooling and config area:BYOB An issue with the BYOB framework labels Aug 1, 2023
@laurentsimon laurentsimon added this to the BYOB framework GA milestone Aug 1, 2023
@laurentsimon laurentsimon mentioned this issue Aug 1, 2023
Merged
@laurentsimon
Copy link
Collaborator Author

The internal callback Action also has a ref that needs to be kept in sync

This was referenced Aug 1, 2023
Merged
Open
laurentsimon added a commit that referenced this issue Aug 2, 2023
@laurentsimon
feat: Keep ref in sync for Maven Actions (#2510)
c3ae3e3 
closes
#2508

We need to keep in sync the checkout of the slsa-github-generator repo

---------

Signed-off-by: laurentsimon <laurentsimon@google.com>
enteraga6 pushed a commit to enteraga6/slsa-github-generator that referenced this issue Aug 8, 2023
@laurentsimon @enteraga6
feat: Keep ref in sync for Maven Actions (slsa-framework#2510)
2929e9c 
closes
slsa-framework#2508

We need to keep in sync the checkout of the slsa-github-generator repo

---------

Signed-off-by: laurentsimon <laurentsimon@google.com>
Signed-off-by: Noah Elzner <elzner@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:BYOB An issue with the BYOB framework area:tooling An issue with project tooling and config
Projects
None yet
Milestone
BYOB framework GA
Development

Successfully merging a pull request may close this issue.

feat: Keep ref in sync for Maven Actions laurentsimon/slsa-github-generator
1 participant
@laurentsimon